Avoid unnecessary builds/rebuilds of `rust-demangler` #117197

Zalathar · 2023-10-26T02:04:13Z

This is a combination of two loosely-related changes:

Don't build rust-demangler as a dependency of tests/run-make, because after Convert run-make/coverage-reports tests to use a custom compiletest mode #112300 none of the remaining run-make tests actually use it. (If future run-make tests ever do need the demangler, it'll be easy to add it back.)
For tests/run-coverage, build the demangler with the stage 0 compiler instead of the current-stage compiler. This avoids having to uselessly rebuild the demangler after modifying and rebuilding the compiler itself.

rustbot · 2023-10-26T02:04:21Z

(rustbot has picked a reviewer for you, use r? to override)

The demangler was only needed by coverage tests, but those tests were migrated into their own custom test mode in rust-lang#112300. This avoids having to build the demangler just for run-make tests. It will still be built as needed by run-coverage tests or for other purposes.

This avoids useless rebuilds of the demangler when modifying the compiler.

onur-ozkan · 2023-10-27T20:00:43Z

@bors r+ rollup=iffy

bors · 2023-10-27T20:00:46Z

📌 Commit 36c3f90 has been approved by onur-ozkan

It is now in the queue for this repository.

bors · 2023-10-28T01:04:38Z

⌛ Testing commit 36c3f90 with merge c6eb61a...

bors · 2023-10-28T03:01:00Z

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing c6eb61a to master...

rust-timer · 2023-10-28T08:26:11Z

Finished benchmarking commit (c6eb61a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[1.3%, 1.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.3%	[1.3%, 1.3%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.4%, 3.7%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 635.428s -> 635.236s (-0.03%)
Artifact size: 304.56 MiB -> 304.58 MiB (0.01%)

rustbot assigned onur-ozkan Oct 26, 2023

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 26, 2023

Swatinem approved these changes Oct 26, 2023

View reviewed changes

Zalathar added 2 commits October 27, 2023 17:18

For run-coverage tests, build rust-demangler with the stage 0 compiler

36c3f90

This avoids useless rebuilds of the demangler when modifying the compiler.

Zalathar force-pushed the demangler branch from da655e9 to 36c3f90 Compare October 27, 2023 06:21

onur-ozkan approved these changes Oct 27, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 28, 2023

bors merged commit c6eb61a into rust-lang:master Oct 28, 2023
12 checks passed

rustbot added this to the 1.75.0 milestone Oct 28, 2023

Zalathar deleted the demangler branch October 28, 2023 03:09

bjorn3 mentioned this pull request Oct 28, 2023

Run part of rustc_codegen_gcc's tests in CI #117313

Merged

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid unnecessary builds/rebuilds of `rust-demangler` #117197

Avoid unnecessary builds/rebuilds of `rust-demangler` #117197

Zalathar commented Oct 26, 2023

rustbot commented Oct 26, 2023

onur-ozkan commented Oct 27, 2023

bors commented Oct 27, 2023

bors commented Oct 28, 2023

bors commented Oct 28, 2023

rust-timer commented Oct 28, 2023

Avoid unnecessary builds/rebuilds of rust-demangler #117197

Avoid unnecessary builds/rebuilds of rust-demangler #117197

Conversation

Zalathar commented Oct 26, 2023

rustbot commented Oct 26, 2023

onur-ozkan commented Oct 27, 2023

bors commented Oct 27, 2023

bors commented Oct 28, 2023

bors commented Oct 28, 2023

rust-timer commented Oct 28, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Avoid unnecessary builds/rebuilds of `rust-demangler` #117197

Avoid unnecessary builds/rebuilds of `rust-demangler` #117197